-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for raft logger changes #540
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
I'll be on vacation next week and this PR has downstream consequences so I've marked it as "DO NOT MERGE" until I get back, but I would love to get it reviewed in advance so that I can safely merge when I'm ready. |
The devcontainer failures are expected here until we merge the raft PR. |
/merge |
This PR updates cuml to use raft's updated logger implementation using [rapids-logger](https://github.com/rapidsai/rapids-logger). This PR requires rapidsai/cuvs#540 (cuml requires both raft and cuvs updates). Contributes to rapidsai/build-planning#104 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #6187
This PR updates cuvs to use raft's updated logger implementation using rapids-logger. It is a breaking change because it changes the kmeans
base_params
verbosity type from an int to araft::level_enum
.This PR requires rapidsai/raft#2530.
Contributes to rapidsai/build-planning#104