Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for raft logger changes #540

Merged
merged 11 commits into from
Dec 31, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 17, 2024

This PR updates cuvs to use raft's updated logger implementation using rapids-logger. It is a breaking change because it changes the kmeans base_params verbosity type from an int to a raft::level_enum.

This PR requires rapidsai/raft#2530.

Contributes to rapidsai/build-planning#104

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 17, 2024
@vyasr vyasr self-assigned this Dec 17, 2024
Copy link

copy-pr-bot bot commented Dec 17, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 18, 2024

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Dec 19, 2024

I'll be on vacation next week and this PR has downstream consequences so I've marked it as "DO NOT MERGE" until I get back, but I would love to get it reviewed in advance so that I can safely merge when I'm ready.

@vyasr vyasr marked this pull request as ready for review December 19, 2024 20:24
@vyasr vyasr requested review from a team as code owners December 19, 2024 20:24
@vyasr vyasr requested a review from KyleFromNVIDIA December 19, 2024 20:24
ci/build_cpp.sh Outdated Show resolved Hide resolved
ci/build_python.sh Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Dec 19, 2024

The devcontainer failures are expected here until we merge the raft PR.

@github-actions github-actions bot removed the ci label Dec 30, 2024
@vyasr vyasr added breaking Introduces a breaking change and removed DO NOT MERGE non-breaking Introduces a non-breaking change labels Dec 30, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Dec 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit a572273 into rapidsai:branch-25.02 Dec 31, 2024
58 checks passed
@vyasr vyasr deleted the feat/raft_logger branch December 31, 2024 00:14
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Dec 31, 2024
This PR updates cuml to use raft's updated logger implementation using [rapids-logger](https://github.com/rapidsai/rapids-logger).

This PR requires rapidsai/cuvs#540 (cuml requires both raft and cuvs updates).

Contributes to rapidsai/build-planning#104

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #6187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change CMake cpp improvement Improves an existing functionality
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants